My problem with Ally McCoist is that he thinks he is a lot more interesting than he actually is. He will make a banal observation which he thinks is really important, but gets no response from the co-commentator. And then he goes on to repeat exactly the same observation three or four more times over the next couple of minutes. He can't let it go.
I'm probably in a minority, as I've just read he's won Pundit of the Year.
Then again, I also don't like Gary Neville as an analyst. Whereas I think Gary Lineker is brilliant. He is so good at explaining complex stuff very simply. It probably helps that he's also very engaging and likeable.